-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix add jindocache engine for jindodata 5.0 beta release #3346
Conversation
.dlv/config.yml
Outdated
@@ -0,0 +1,54 @@ | |||
# Configuration file for the delve debugger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the file, it's for debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Library/Caches/go-build/README
Outdated
@@ -0,0 +1,4 @@ | |||
This directory holds cached build artifacts from the Go build system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -0,0 +1,513 @@ | |||
/* | |||
Copyright 2022 The Fluid Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header year should be 2023.
apiVersion: apps/v1 | ||
kind: DaemonSet | ||
metadata: | ||
name: {{ template "jindofs.fullname" . }}-fuse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the chart name is changed to jindocache, I think the name jindofs should be changed to jindocache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
chart: {{ template "jindofs.chart" . }} | ||
release: {{ .Release.Name }} | ||
heritage: {{ .Release.Service }} | ||
role: jindofs-fuse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the role name be jindocache-fuse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@frankleaf please fix the unit test first. thanks. |
Codecov Report
@@ Coverage Diff @@
## master #3346 +/- ##
==========================================
- Coverage 65.43% 64.51% -0.92%
==========================================
Files 402 432 +30
Lines 23244 25745 +2501
==========================================
+ Hits 15209 16609 +1400
- Misses 6254 7165 +911
- Partials 1781 1971 +190
|
Signed-off-by: frankleaf <[email protected]>
Signed-off-by: frankleaf <[email protected]>
Signed-off-by: frankleaf <[email protected]>
Signed-off-by: frankleaf <[email protected]>
Signed-off-by: frankleaf <[email protected]>
Signed-off-by: frankleaf <[email protected]>
Signed-off-by: frankleaf <[email protected]>
Signed-off-by: frankleaf <[email protected]>
/test fluid-e2e |
"efc": efc.Build, | ||
"alluxio": alluxio.Build, | ||
"jindo": jindo.Build, | ||
"jindofsx": jindofsx.Build, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about puting jindo,jindofsx and jindocache together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
.gitignore
Outdated
@@ -40,3 +40,6 @@ sdk | |||
**/__debug_bin | |||
**/__pycache__ | |||
|
|||
# local related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not neccessay for developers. Please remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: frankleaf <[email protected]>
Signed-off-by: frankleaf <[email protected]>
Signed-off-by: frankleaf <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/test fluid-e2e |
/retest |
/test fluid-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews